search

RFD-FHEM / RFFHEM

Counterpart of SIGNALDuino, it's the code for FHEM to work with the data received from the uC
GNU General Public License v3.0
44 stars 33 forks source link

Unable to set Clients attribute #1264

Closed Devirex closed 1 day ago

Devirex commented 3 weeks ago

This return statement does not allow to set the Clients attribute. If removed it works good. https://github.com/RFD-FHEM/RFFHEM/blob/be887b5a07a4fcd5deac31b7854e1e14bbd1296b/FHEM/00_SIGNALduino.pm#L3120

sidey79 commented 3 weeks ago

Can i have some more details how to reproduce the error?

Devirex commented 3 weeks ago

Sure, just try to add another value to the list of existing Clients. Copy all the existing Clients from the internals, and add some module (maybe a new module which is in development) to the string. There is always a message „Setting defaults“ and no attribute „Clients“ is added to a device. If you comment out that line everything works as expected. You can then set all Clients for which messages should be dispatched.

sidey79 commented 3 weeks ago

I got it, the internal ist updated but the attribute self isn't set to the provided value.

sidey79 commented 3 weeks ago

I've fixed the error, can you give it a try?

update force https://raw.githubusercontent.com/RFD-FHEM/RFFHEM/sidey79/issue1264/controls_signalduino.txt

Devirex commented 3 weeks ago

Setting the Attribute now works good (added MY_Module): ClientList

But a "shutdown restart" resets the value (to the Clients from "selected protocols"?) without using the custom values from the Attribute ClientList-broken

sidey79 commented 3 weeks ago

Can you confirm, that you are not using the whitelist_IDs attribute? Because, if you use the Whitelist_IDs attribute, the Clientlist ist created from the modules selected matching the modules listed in the whitelist_IDs attribute.

If you want to control the Clients attribute by yourself, then you can't use the whitelist_IDs attribute.

Devirex commented 3 weeks ago

Ok thanks for the hint 👍I removed the whitelist_ID Atrributes. Now the Clients are defaulting to standard after reboot even if attribute Clients is set.

sidey79 commented 3 weeks ago

Okay, i will check this.

sidey79 commented 2 weeks ago

I updated the code and i think the reload problem is now also fixed. You can update with the same url as last time.

sidey79 commented 3 days ago

@Devirex

Do you have an update for us?

Devirex commented 2 days ago

Hey sorry for the delay, works great now!