Add swap APIs - Githubissues

RGB-Tools / rgb-lightning-node

MIT License

17 stars 19 forks source link

Add swap APIs #18

Closed danielabrozzoni closed 4 months ago

danielabrozzoni commented 9 months ago

Add vanilla support for opening a channel, keysend, send
Add /makerinit, /trader, /makerexecute, /listtrades
Fix a bug where you couldn't open a channel pushing 0 sats

zoedberg commented 9 months ago

Fix a bug where you couldn't open a channel pushing 0 sats

That's not a bug and the way you fixed it:

-        if payload.push_msat < DUST_LIMIT_MSAT {
+        if payload.push_msat != 0 && payload.push_msat < DUST_LIMIT_MSAT {

is incorrect.

The push amount check should be performed only when opening RGB channels, for vanilla channels I don't think we need to deny push amounts between 1 and DUST_LIMIT_MSAT. If you think I'm wrong please provide an explanation.

danielabrozzoni commented 8 months ago

Thanks, I updated and rebased

danielabrozzoni commented 6 months ago

In my last push:

Rebase
Address of all review comments
Add asset<->asset swaps

Some tests are sometimes failing due to https://github.com/lightningdevkit/rust-lightning/issues/2479

zoedberg commented 4 months ago

closing this since feature has been rebased, fixed and merged upstream. thank you