search

RGB-Tools / rgb-lightning-node

MIT License
17 stars 19 forks source link

bump rust + fix rgb-lib version #21

Closed vincenzopalazzo closed 7 months ago

vincenzopalazzo commented 7 months ago

This is a minor change that require also updating the rust-lightning to compile it on my system

Idk if I am missing something related to rust 1.74 due https://github.com/rust-lang/rust/issues/115188

See commits for error description

Depending from https://github.com/RGB-Tools/rust-lightning/pull/3

zoedberg commented 7 months ago

If you don't run cargo update this fix should not be needed because the Cargo.lock file is pointing to the correct dependencies. Anyway it's my fault that I've pointed rgb-lib to master, I should have pointed it to a dedicated branch instead.

If you want to fix my error you can update this PR changing rgb-lib branch from master to rln_v0.10 and if you want to fix also the rust-toolchain.toml file then you can remove the TODO and put stable in place of 1.71.

vincenzopalazzo commented 7 months ago

Thanks! @zoedberg

Force push the change that you suggest, and also modify the ldk version with the correct branch of rgb-lib

vincenzopalazzo commented 7 months ago

Included the https://github.com/RGB-Tools/rust-lightning/pull/3 change :) not it is ready to review nad merge if it is all ok

vincenzopalazzo commented 7 months ago

Done! Thanks for the review!