search

RGB-WG / rgb-core

RGB Core Library: consensus validation for private & scalable client-validated smart contracts on Bitcoin & Lightning
https://spec.rgb.tech
Apache License 2.0
207 stars 50 forks source link

suppress eprint #203

Closed nicbus closed 9 months ago

nicbus commented 10 months ago

The output from the following eprint appears on the console:

"Warning: current version of RGB Core doesn't support production of bulletproofs; thus, fungible state must be never kept concealed"

This is inconvenient and I think this output should be suppressed.

I propose to protect the eprint behind a feature flag (e.g. log).

dr-orlovsky commented 9 months ago

The purpose of this eprint is to make sure that we do not do something wrong with bulletproof while they are not working here. It helps to control how many times this method is called (and it must not be called any time except the validation).

I mean if we would ever try to store something containing bulletproof we will instantly see this eprint.

So while it is inconvenient, I think before releasing v0.11 it's better to keep it there.

dr-orlovsky commented 9 months ago

Ok, I came up with a better solution: https://github.com/RGB-WG/rgb-core/pull/210

nicbus commented 9 months ago

I agree that's a better solution.