Closed dr-orlovsky closed 1 month ago
Attention: Patch coverage is 0%
with 18 lines
in your changes are missing coverage. Please review.
Project coverage is 15.4%. Comparing base (
52e9dcb
) to head (7472d06
). Report is 38 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@crisdut well, the whole idea is to merge this PR after v0.11 release (i.e. in v0.12), while we need the refactored opcodes in v0.11, thus your PR can't be based on this one
@crisdut well, the whole idea is to merge this PR after v0.11 release (i.e. in v0.12), while we need the refactored opcodes in v0.11, thus your PR can't be based on this one
Do you mean refactor the common opcodes in the aluvm or the contract-level opcodes in the rgb-core vm?
@crisdut well, the whole idea is to merge this PR after v0.11 release (i.e. in v0.12), while we need the refactored opcodes in v0.11, thus your PR can't be based on this one
Do you mean refactor the common opcodes in the aluvm or the contract-level opcodes in the rgb-core vm?
He was referring to the average contract-level opcodes in the RGB, because this PR is about state verifications on the "current state" of the contract.
Yes, I agree with you, we need to refactor the contract-level opcodes, and then maybe there is a lack of the other state types.
Closing in favor of #264
This is WIP on adding contract state (not just operation state, but whole contract state) to the VM required for https://github.com/RGB-WG/rgb-core/pull/201
It seems like this will require refactoring of the validation workflow, since now we must evaluate the contract state not in stdlib, but right during the validation procedure itself...
I think it will be nice to postpone this until v0.12
NB: this is WIP since the global state for the contract IS NOT COMPUTED, i.e. validator always sees an empty contract state.