Move ReservedBytes to commit_verify crate

dr-orlovsky commented 6 months ago

Required for https://github.com/BP-WG/bp-core/pull/81 Counterpart of https://github.com/LNP-BP/client_side_validation/pull/161

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.3%. Comparing base (2e01d87) to head (7d611b3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #222 +/- ## ======================================== + Coverage 15.2% 15.3% +0.1% ======================================== Files 33 33 Lines 4267 4218 -49 ======================================== - Hits 648 646 -2 + Misses 3619 3572 -47 ``` | [Flag](https://app.codecov.io/gh/RGB-WG/rgb-core/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/RGB-WG/rgb-core/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | `15.3% <ø> (+0.1%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

zoedberg commented 6 months ago

I cannot try this PR on rgb-lib because it breaks rgb-std compilation:

   Compiling rgb-std v0.11.0-beta.4 (https://github.com/RGB-WG/rgb-std?branch=master#88e02209)
error[E0432]: unresolved import `crate::ReservedBytes`
  --> /home/zoe/.cargo/git/checkouts/rgb-std-adbac1111552c725/88e0220/src/interface/iimpl.rs:42:13
   |
42 | use crate::{ReservedBytes, LIB_NAME_RGB_STD};
   |             ^^^^^^^^^^^^^ no `ReservedBytes` in the root
   |
   = help: consider importing this struct instead:
           commit_verify::ReservedBytes

For more information about this error, try `rustc --explain E0432`.
error: could not compile `rgb-std` (lib) due to 1 previous error

dr-orlovsky commented 6 months ago

@zoedberg I pushed a commit with re-export. Should work now

RGB-WG / rgb-core

Move ReservedBytes to commit_verify crate #222

Codecov Report