search

RGB-WG / rgb-core

RGB Core Library: consensus validation for private & scalable client-validated smart contracts on Bitcoin & Lightning
https://spec.rgb.tech
Apache License 2.0
207 stars 52 forks source link

Introduce u8 wrapper for decimal precision #88

Closed kaiwolfram closed 2 years ago

kaiwolfram commented 3 years ago

Issue RGB-WG/rust-rgb20#1

kaiwolfram commented 2 years ago

BTW the build on MSRV is broken due to the upstream dependency

That's not an issue anymore since your last commit, right?

dr-orlovsky commented 2 years ago

No, this is still an issue, but I will raise MSRV in some next PR and will unlock PR merging with that

dr-orlovsky commented 2 years ago

May I ask you please to move this wonderful type implementation to RGB standard lib where this type will be actually used as a part of RGB20? This repo will have only consensus-critical code and type restrictions are implemented here at the level of state encoding schema

kaiwolfram commented 2 years ago

May I ask you please to move this wonderful type implementation to RGB standard lib where this type will be actually used as a part of RGB20?

Sure. Does this fit into src/fungible/amount.rs or should I move it somewhere else?

dr-orlovsky commented 2 years ago

Yes, that is the perfect place.

kaiwolfram commented 2 years ago

Opened a new PR: https://github.com/RGB-WG/rgb-std/pull/2