RGB-WG / rgb-node

RGB node - the official server-side implementation
https://rgb.tech
MIT License
148 stars 43 forks source link

Switch from dotenv to dotenvy #240

Closed monaka closed 1 year ago

monaka commented 1 year ago

Signed-off-by: Masaki Muranaka monaka@monami-ya.com

zoedberg commented 1 year ago

is dotenv actually necessary? it doesn't seem used

dr-orlovsky commented 1 year ago

I was orignally using it to parse information from environment variables when the nodes start (when environment is used to replace command-line parameters).

monaka commented 1 year ago

I can remove dotenv|dotenvy from Cargo.toml and re-push it here. It seems cargo audit alerts by content in Cargo.lock. I just want to suppress alerts.

dr-orlovsky commented 1 year ago

I am quite sure the node won't compile without this dependency

zoedberg commented 1 year ago

I am quite sure the node won't compile without this dependency

It's not used so it should compile. To be sure I checked and I can confirm it builds without it.

While checking I've found other dependencies that are unused so I've opened https://github.com/RGB-WG/rgb-node/pull/241. I think this PR can be closed

dr-orlovsky commented 1 year ago

Ok, closing in favor of merged #241