search

RGB-WG / rgb-schemata

Standard RGB schemata and schema compiler
Apache License 2.0
29 stars 20 forks source link

disable aluvm log feature #34

Closed nicbus closed 5 months ago

nicbus commented 5 months ago

This PR disables aluvm's log feature (ref. https://github.com/AluVM/rust-aluvm/issues/101) to prevent verbose messages being printed.

dr-orlovsky commented 5 months ago

I'd like to keep it until the release

It really helps me when I write more schema - and also helps to keep track that nothing gets broken.

What is the reason you'd like to remove it now?

nicbus commented 5 months ago

I think those messages should be removed as they should not appear during normal operation and they make reading logs from applications using RGB harder.

In other words, I think aluvm's log feature should be enabled when developing but not in master.

dr-orlovsky commented 5 months ago

Before the release RGB shouldn't be used for real assets. So is it that these logs make your debugging harder?

nicbus commented 5 months ago

This is not being used for real assets, it's used to test the upcoming v0.11 is working as expected and yes, these logs make it harder to to review and debug the logs from the higher-level application.

I can live with this, so if they're so important to you at the moment, let's keep them. Please leave this open as a reminder so we can drop the logs when they won't be as useful to you as they are now.

nicbus commented 5 months ago

Can we remove it in the dependencies and add as a feature at the crate level?

Even better, done.