search

RGB-WG / rgb-std

RGB standard libs for WASM & low-level integrations (no FS/networking)
https://rgb.tech
Apache License 2.0
66 stars 30 forks source link

add rights, attachment operations #219

Closed cymqqqq closed 4 months ago

cymqqqq commented 4 months ago

Description:

now, there are fungible_ops, and data_ops related to FungibleAllocation, and DataAllocation, so I think we can also have rights_ops, attachment_ops related to RightsAllocation, AttachAllocation.

  1. add rights_ops interface
  2. add attachment_ops interface
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 17.0%. Comparing base (34792e5) to head (e27ece8). Report is 3 commits behind head on master.

Files Patch % Lines
src/interface/contract.rs 0.0% 30 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #219 +/- ## ======================================== - Coverage 17.1% 17.0% -0.1% ======================================== Files 37 37 Lines 7334 7379 +45 ======================================== Hits 1257 1257 - Misses 6077 6122 +45 ``` | [Flag](https://app.codecov.io/gh/RGB-WG/rgb-std/pull/219/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/RGB-WG/rgb-std/pull/219/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | `17.0% <0.0%> (-0.1%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cymqqqq commented 4 months ago

There is a question: I found the info: ContractInfo defined in the ContractIface, but it seems like it's not used in this struct and all the interfaces defined in the ContractIface.

dr-orlovsky commented 4 months ago

but it seems like it's not used in this struct and all the interfaces defined in the ContractIface.

What do you mean by "not used"? It is subject to be used by software integrating RGB: this is how it gets information about the contract like if it is on testnet, creation identity and timestamp etc.