search

RGB-WG / rgb-std

RGB standard libs for WASM & low-level integrations (no FS/networking)
https://rgb.tech
Apache License 2.0
66 stars 30 forks source link

collect signatures from the stash #232

Closed cymqqqq closed 4 months ago

cymqqqq commented 4 months ago

Description:

  1. Add sigs_for in the stash reader provider
  2. Collect genesis, scheme, iface, and iimpl signatures from the stash provider

Questions: I don't understand the following TODO

  1. Conceal everything we do not need. (conceal seal, transition, and state?)
  2. Add known sigs to the consignment. (What's the difference from the collect signatures from the stash?)

And the know sigs, do you mean the content signatures from the stash or the signatures from the disclosure? (In the Disclosure, there is PublicKey, Signature Key-Value map).

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 42.50000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 20.5%. Comparing base (7f637c6) to head (5a0d3f4). Report is 5 commits behind head on master.

Files Patch % Lines
src/persistence/stock.rs 28.1% 23 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #232 +/- ## ======================================== + Coverage 17.6% 20.5% +3.0% ======================================== Files 37 37 Lines 7535 7666 +131 ======================================== + Hits 1323 1574 +251 + Misses 6212 6092 -120 ``` | [Flag](https://app.codecov.io/gh/RGB-WG/rgb-std/pull/232/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | Coverage Δ | | |---|---|---| | [rust](https://app.codecov.io/gh/RGB-WG/rgb-std/pull/232/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG) | `20.5% <42.5%> (+3.0%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=RGB-WG#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.