RGLab / CytoML

A GatingML Interface for Cross Platform Cytometry Data Sharing
GNU Affero General Public License v3.0
30 stars 14 forks source link

fix linear transformation parsing bug #143

Closed mikejiang closed 2 years ago

mikejiang commented 2 years ago

That bug was introduced when porting some changes from internal repo where we re-factored XML parsing by using pugixml, and its xpath query syntax is slightly different from libxml2 which is the one used by open source repo.(it doesn't take namespace prefix ,i.e. transforms:maxRange, and silently failed when received such property name).

that was the root cause of erroneous scaling on FCS-A, SSC_A. (reported by #142).

It took a while to figured it out ,the fix is easy though.

Here is the new parsing results image

mlamarin commented 2 years ago

Hello @mikejiang I have approved the changes. It seems that it was the only thing I could do. I am not very familiar with the dev process in GitHub. I hope I did the right thing and that you can merge this in master. Tell me if it's not the case. Thanks very much for having fixed the bug. It will make some folks's life easier in the team. Best Marc