search

RGLab / MAST

Tools and methods for analysis of single cell assay data in R
226 stars 57 forks source link

Better validity checking for combine methods #27

Closed amcdavid closed 8 years ago

amcdavid commented 11 years ago

When using combine to add to the featureData or cellData, we should make it harder to incorrectly add data by matching by row.names or a common field if possible.

gfinak commented 11 years ago

A fast way to do this would be with data.table..

On Wed, Sep 25, 2013 at 3:16 PM, Andrew McDavid notifications@github.comwrote:

When using combine to add to the featureData or cellData, we should make it harder to incorrectly add data by matching by row.names or a common field if possible.

— Reply to this email directly or view it on GitHubhttps://github.com/RGLab/SingleCellAssay/issues/27 .

Greg Finak, PhD Staff Scientist Vaccine and Infectious Disease Division Fred Hutchinson Cancer Research Center Seattle, WA 98109

(206)667-3116 gfinak@fhcrc.org

amcdavid commented 11 years ago

Yeah, I don't think this is a huge time bottleneck at the moment, and everything is internally represented as an AnnotatedDataframe anyways.

On Wed, Sep 25, 2013 at 3:19 PM, Greg Finak notifications@github.comwrote:

A fast way to do this would be with data.table..

On Wed, Sep 25, 2013 at 3:16 PM, Andrew McDavid notifications@github.comwrote:

When using combine to add to the featureData or cellData, we should make it harder to incorrectly add data by matching by row.names or a common field if possible.

— Reply to this email directly or view it on GitHub< https://github.com/RGLab/SingleCellAssay/issues/27> .

Greg Finak, PhD Staff Scientist Vaccine and Infectious Disease Division Fred Hutchinson Cancer Research Center Seattle, WA 98109

(206)667-3116 gfinak@fhcrc.org

— Reply to this email directly or view it on GitHubhttps://github.com/RGLab/SingleCellAssay/issues/27#issuecomment-25129546 .