search

RGLab / MAST

Tools and methods for analysis of single cell assay data in R
226 stars 57 forks source link

thresholdSCRNACountMatrix is brittle with small sample sizes #64

Closed amcdavid closed 8 years ago

amcdavid commented 8 years ago
  1. If the min_per_bin argument is actually used, then we attempt to index into non-existent elements of the cutpoints list
  2. vals2 is null sometimes and perhaps should not be
  3. Try to guess if the data has been log transformed or not.
gfinak commented 8 years ago

Do you have some example data we can use to debug?

gfinak commented 8 years ago

I've pushed a possible fix. Needs more testing, but there was an index out of bounds in a loop that organized the ordering of the thresholds, If this looks good to you, feel free to merge to master.

amcdavid commented 8 years ago

Closed in 9c3255f