Create the separate view class for subsetting operations on CytoFrame

RGLab / cytolib

c++ library for representing and interacting the gated cytometry data structure

GNU Affero General Public License v3.0

12 stars 11 forks source link

Create the separate view class for subsetting operations on CytoFrame #5

Closed mikejiang closed 5 years ago

mikejiang commented 6 years ago

Currently row_idx and col_idx are stored within CytoFrame class and it seems to be incorrect design since we can't do the efficient subsetting without impacting the original object. The solution is to detach these idx and have a separate proxy class CytoFrameView to store them along with the shared_ptr of CytoFrame