RGLab / flowStats

flowStats: algorithms for flow cytometry data analysis using BioConductor tools
15 stars 10 forks source link

warpSet: undocumented ceiling and floor processing #15

Closed SamGG closed 7 years ago

SamGG commented 9 years ago

While applying warp function to the data, lines 727-775, the process also do ceiling and floor. Unfortunately, this is undocumented. I feel this is not the original aim. I do understand that the warping functions are computed on a specific range (lines 625-639), but they are numerically valid out of this range. NB: the range is explicitly extended by 15% (lines 626-628) before looking for warping functions but original data is clipped using original range before data warping . IMHO, ceiling and floor processing is an interesting function that should be available per se and warpSet should do only warping. Alternatively, for back compatibility, there could be an option that deactivate ceiling and floor process, but I am unsure about how to manage new range. Right now, I am going to extend the current range of my data which is the most simple thing. Nevertheless, documentation should be updated.