RGLab / flowStats

flowStats: algorithms for flow cytometry data analysis using BioConductor tools
15 stars 10 forks source link

Fix spillover bugs #42

Closed malisas closed 2 years ago

malisas commented 2 years ago

This PR fixes #39 and #41

For #41 (issue in spillover_ng : rows are swapped), the problem was that the rows of the returned compensation matrix were being ordered an extra time. This was not caught by the existing tests because those tests have the property that channel_order == order(channel_order). The helpful example provided in #41 does not have this property.

inten <- inten[order(channel_order),] is now simply inten <- inten[channel_order,]