RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
44 stars 21 forks source link

Handle "derived parameters" #262

Open gfinak opened 5 years ago

gfinak commented 5 years ago

flowJo has "derived parameters". At the moment flowWorkspace doesn't handle these at all. It simply says that "the parameter is not found in the flow data". Instead, it would be better if we could detect that there is a derived parameter and simply ignore it. Otherwise, the workspace needs to be edited in flowJo to remove those parameters (assuming they aren't needed for a particular use case).

mikejiang commented 5 years ago

Once we've switched to cytolib v2, we can consider to merge the derived parameters to flow data so that these gates can be parsed as regular one. For now I simply skip them as you suggested. Please try the patch to see if it works for you.

gfinak commented 5 years ago

Thanks, Mike. I'll take it for a spin tomorrow.

PedroMilanezAlmeida commented 4 years ago

Hey guys, I wonder whether it is possible now to parse derived parameters from FLowJo.

I saw here that, as of Nov 8, 2018, "parseWorkspace will still skip any gates (and its descendants ) that are associcated with derived-parameter".

I also wonder whether these gates (i.e., based on derived parameters) are supported now and, if not, whether you plan to add that capability.