RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
45 stars 21 forks source link

Inverse Transform GatingSet #301

Open DillonHammill opened 4 years ago

DillonHammill commented 4 years ago

Hi @mikejiang and @jacobpwagner,

I have always wanted to be able to inverse transform a GatingSet. I have been playing around with it for a while now, I think I have a way of doing it. I written a function to run through and inverse transform the gates and I am coupling this with inverse transforming the underlying cytoset. This seems to work well but I will need to do some more testing.

I was wondering if we could add an inverse flag to the GatingSet to signal when transformations have been inversed (and still keep the transformers attached to the GatingSet), or alternatively have a way to remove the transformers attached to the GatingSet when transformations are inversed (i.e. the reverse of set_transformations)? Perhaps reset_transformations?

Keen to hear your thoughts.

Thanks for your help!

Dillon