search

RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
44 stars 21 forks source link

Problems with imports from *methods* package #313

Open naskomit opened 4 years ago

naskomit commented 4 years ago

Hi and thank you for this package. We have R codebase which uses flowWorkspace, and have been using it for years. Right now we are converting it into an R package. But suddenly code, which was working before is not anymore. For example calling load_gs which calls .load_gs fails, because this function uses .hasSlot which R doesn't find. When getting an element of a gating set e.g. gs[[1]], the function new is being called (creating GatingHierarchy objecy), and R complains it doesn't find it. Both functions are part of the methods package, and are normally auto-loaded into R. However, it seems that since we converted the R code into package, they are not found, for some reason. I checked your NAMESPACE file, and you are not explicitly importing them. So, I am not 100% sure this is a bug, but what is your take on it, and do you know how we can solve it?

gfinak commented 4 years ago

Can you provide a minimum example? Sounds like you need to import things properly into your package. flowWorkspace is used by plenty of packages without issues.