search

RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
45 stars 21 forks source link

add cf_append_cols #316

Closed mikejiang closed 4 years ago

mikejiang commented 4 years ago

fr_append_cols doesn't work out-of-box for cytoframe due to its usage of some flowframe-specific internals. We will need to have adapted version of it.

mikejiang commented 4 years ago 
exprs(cf) <- cbind(exprs(cf), cols)
Error in cf_setData(object@pointer, value) : 
  The size of the input data is different from the cytoframe view!

Looks like it requires deeper changes to the data setter at cytolib level in order to allow expanding the cytoframe data size

mikejiang commented 4 years ago

As the commits message states, relaxing the rule of data setter at cytolib level in order for this appending column to work will trigger the cascade effect of exceptions. For now, I will simply wrap around flowFrame's method to achieve the goal, which may not be optimal in speed. But we will revisit this if the efficiency becomes an issue (hopefully not noticeable for this single cytoframe operation)