RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
45 stars 21 forks source link

gs_pop_get_children throwing error #322

Closed luigidolcetti closed 4 years ago

luigidolcetti commented 4 years ago

Hi, I am having some troubles with children and parents retrieval. Let's say I have a tree that looks like this:

/root /1 /2 /3 .... /1/Doublets /2/Doublets ... /1/Non-Doublets /2/Non-Doublets .... /1/Non-Doublets/1 /1/Non-Doublets/2..... /LIVE /DEAD (/LIVE by is 1/Non-Doublets/1 | 1/Non-Doublets/5 | ....) /LIVE/1 /LIVE/2 /LIVE/3 ....

now, gs_pop_get_parent(gatingSet,'/LIVE/1') = /LIVE gs_pop_get_parent(gatingSet,'/LIVE') = root (... but I suppose this is normal with boolean filter... I mean so far it's the only behavior I noticed although having a trace-back would be useful)

my real troubles start here:

gs_pop_get_children(gatingSet,'/LIVE') =

Error in .cpp_getChildren(obj@pointer, sampleNames(obj), y, showHidden) : Expecting a single string value: [type=character; extent=2].

gs_pop_get_children(gatingSet,'/1') = ... same story

Any idea?

Thank you in advance, Luigi

gfinak commented 4 years ago

I can confirm I can reproduce this error. We'll get on a fix asap.

flowWorkspace_3.99.22
jacobpwagner commented 4 years ago

@luigidolcetti , https://github.com/RGLab/flowWorkspace/commit/0217354f1b04aa89dab8845e9f58f98b6508170c should fix it. Thanks for bringing this to our attention and please let us know if you run in to any additional issues.

luigidolcetti commented 4 years ago

Perfect! works like a charm!

Thank you very much, Luigi


From: Jake Wagner notifications@github.com Sent: 23 April 2020 17:22 To: RGLab/flowWorkspace flowWorkspace@noreply.github.com Cc: Dolcetti, Luigi luigi.dolcetti@kcl.ac.uk; Mention mention@noreply.github.com Subject: Re: [RGLab/flowWorkspace] gs_pop_get_children throwing error (#322)

@luigidolcettihttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fluigidolcetti&data=01%7C01%7Cluigi.dolcetti%40kcl.ac.uk%7C9c01f2ec314a475fed8008d7e7a27862%7C8370cf1416f34c16b83c724071654356%7C0&sdata=JHnU6sU2Ya6Dv6crI4IR%2FeU4K1PrJVW3SrVIO6aYQhw%3D&reserved=0 , 0217354https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRGLab%2FflowWorkspace%2Fcommit%2F0217354f1b04aa89dab8845e9f58f98b6508170c&data=01%7C01%7Cluigi.dolcetti%40kcl.ac.uk%7C9c01f2ec314a475fed8008d7e7a27862%7C8370cf1416f34c16b83c724071654356%7C0&sdata=QCQq8d%2B%2BpY1%2FucmwVwjgPPOQwl4LCGAYV1Ski8odYNM%3D&reserved=0 should fix it. Thanks for bringing this to our attention and please let us know if you run in to any additional issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRGLab%2FflowWorkspace%2Fissues%2F322%23issuecomment-618496885&data=01%7C01%7Cluigi.dolcetti%40kcl.ac.uk%7C9c01f2ec314a475fed8008d7e7a27862%7C8370cf1416f34c16b83c724071654356%7C0&sdata=y66dbgGjeSr2GiD58krF9Z2VQJYsXRi8GGghrTPGwyI%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPFI7AXGAFRMPRTSXKT2ONTROBTK7ANCNFSM4MO6MBVA&data=01%7C01%7Cluigi.dolcetti%40kcl.ac.uk%7C9c01f2ec314a475fed8008d7e7a27862%7C8370cf1416f34c16b83c724071654356%7C0&sdata=vbQ5Ho3qZfVcRlajayORPV%2FCJ1RWQzFaqJGN8Of4PYc%3D&reserved=0.