search

RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
44 stars 21 forks source link

Error trying to pass flowFrame to gs_cyto_data #372

Open OuNao opened 2 years ago

OuNao commented 2 years ago

Hi,

The gs_cyto_data documentation show that a cytoset/flowSet/ncdfFlowSet can be used:

Description
Accessor method that gets or replaces the cytoset/flowSet/ncdfFlowSet object in a GatingSet or GatingHierarchy

But the code https://github.com/RGLab/flowWorkspace/blob/79f1b86577589c98bced899759ad06dca05fc127/R/GatingSet_Methods.R#L502 use the pointer slot of the cytoset, so only cytoset is supported.

Maybe the documentation must be corrected and the code must test for cytoset.

Thanks.

djhammill commented 1 year ago

Thanks for reporting this issue @OuNao.

The replacement method for gs_cyto_data() doesn't support flowFrame or cytoframe objects. Currently only cytoset replacement values are supported.

We still want to retain support for replacement using flowSet objects so I have submitted PR #383 to fix this.