This PR addresses the issue raised #372 where gs_cyto_data() replacement method no longer works for flowSet objects.
We don't want to remove support for flowSet objects just yet as many users/developers still create GatingSet objects by passing in flowSet objects - so we need to provide replacement method that supports flowSet objects too.
To fix this, we perform a class check on value and if it isn't a cytoset we convert it using flowSet_to_cytoset() before updating it in the GatingSet.
Successfully tested locally with flowSet, ncdfFlowSet and cytoset replacement values.
This PR addresses the issue raised #372 where
gs_cyto_data()replacement method no longer works forflowSetobjects.We don't want to remove support for
flowSetobjects just yet as many users/developers still createGatingSetobjects by passing inflowSetobjects - so we need to provide replacement method that supportsflowSetobjects too.To fix this, we perform a class check on
valueand if it isn't acytosetwe convert it usingflowSet_to_cytoset()before updating it in the GatingSet.Successfully tested locally with
flowSet,ncdfFlowSetandcytosetreplacement values.