Closed mikejiang closed 7 months ago
Yes I see what you mean, Open source cytolib/flowWorkspace code base already diverges quite significantly from internal repo though, Just want to quickly patch up to pass bioconductor builds (already pushed the patch to their current release and develop branches) and move on. Feel free to submit a PR if you prefer to proposal, I am fine with either.
@mikjiang, I agree with @amcdavid - we should try to support older versions of scales
as well if possible. I've submitted a new PR (#397) to this branch with the required changes.
To fix the bioconductor build failures https://bioconductor.org/checkResults/3.18/bioc-LATEST/flowWorkspace/nebbiolo2-buildsrc.html