Open CarolineFrei opened 8 months ago
Describe the bug The version 1.3 of the scales package renamed the class returned by by scales::trans_new method from transto transform: https://github.com/r-lib/scales/commit/1ed7b9ae09a4fc25cf18c8cdf14009895867cc50
scales
by scales::trans_new method
trans
transform
This breaks the following line in transformerList: https://github.com/RGLab/flowWorkspace/blob/a564dbb03c37349255d420427629bf6ebef00b74/R/GatingSet_Methods.R#L1108C10-L1108C10
To Reproduce Use any script using transformerList.
This throws: Error: 'trans' must be a list of transformer objects (generated by scales::trans_new method
Error: 'trans' must be a list of transformer objects (generated by scales::trans_new method
Expected behavior Should work
SessionInfo: flowWorkspace_4.14.0 scales_1.3.0
Additional context This was discovered when using CytoML::diva_to_gatingsetand should affect many downstream functions using flowWorkspace.
CytoML::diva_to_gatingset
addressed by https://github.com/RGLab/flowWorkspace/pull/393
Describe the bug The version 1.3 of the
scales
package renamed the class returned byby scales::trans_new method
fromtrans
totransform
: https://github.com/r-lib/scales/commit/1ed7b9ae09a4fc25cf18c8cdf14009895867cc50This breaks the following line in transformerList: https://github.com/RGLab/flowWorkspace/blob/a564dbb03c37349255d420427629bf6ebef00b74/R/GatingSet_Methods.R#L1108C10-L1108C10
To Reproduce Use any script using transformerList.
This throws:
Error: 'trans' must be a list of transformer objects (generated by scales::trans_new method
Expected behavior Should work
SessionInfo: flowWorkspace_4.14.0 scales_1.3.0
Additional context This was discovered when using
CytoML::diva_to_gatingset
and should affect many downstream functions using flowWorkspace.