RGLab / flowWorkspace

flowWorkspace
GNU Affero General Public License v3.0
45 stars 21 forks source link

Scales v1.3 renamed "trans" class to "transform" #394

Open CarolineFrei opened 11 months ago

CarolineFrei commented 11 months ago

Describe the bug The version 1.3 of the scales package renamed the class returned by by scales::trans_new method from transto transform: https://github.com/r-lib/scales/commit/1ed7b9ae09a4fc25cf18c8cdf14009895867cc50

This breaks the following line in transformerList: https://github.com/RGLab/flowWorkspace/blob/a564dbb03c37349255d420427629bf6ebef00b74/R/GatingSet_Methods.R#L1108C10-L1108C10

To Reproduce Use any script using transformerList.

This throws: Error: 'trans' must be a list of transformer objects (generated by scales::trans_new method

Expected behavior Should work

SessionInfo: flowWorkspace_4.14.0 scales_1.3.0

Additional context This was discovered when using CytoML::diva_to_gatingsetand should affect many downstream functions using flowWorkspace.

mikejiang commented 11 months ago

addressed by https://github.com/RGLab/flowWorkspace/pull/393