mikejiang
commented
1 month ago The test data generated in temp folder in unit test is pretty small, I doubt this was the major source of contribution to your out of disk problem
Open malcook opened 1 month ago
mikejiang
commented
1 month ago The test data generated in temp folder in unit test is pretty small, I doubt this was the major source of contribution to your out of disk problem
malcook
commented
1 month ago Agreed – this is a minor issue – I nonetheless thought it worth mentioning
~ @. From: Mike Jiang @.> Sent: Thursday, September 5, 2024 12:28 PM To: RGLab/flowWorkspace @.> Cc: Cook, Malcolm @.>; Author @.***> Subject: Re: [RGLab/flowWorkspace] tests/testthat/cleanup_temp.R should arguably fully clean up /tmp but doesn't (Issue #402)
The test data generated in temp folder in unit test is pretty small, I doubt this was the major source of contribution to your out of disk problem—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message
The test data generated in temp folder in unit test is pretty small, I doubt this was the major source of contribution to your out of disk problem
— Reply to this email directly, view it on GitHubhttps://github.com/RGLab/flowWorkspace/issues/402#issuecomment-2332273247, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADWHOSMO46VWLNL34X472TZVCIALAVCNFSM6AAAAABNWLVVY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSGI3TGMRUG4. You are receiving this because you authored the thread.Message ID: @.**@.>>
The tests in tests/testthat/cleanup_temp.R should probably fully delete all the files it creates in the temp directory.
This can be achieved by adding a call to
gs_cleanup_temp(gs_untouched)at the endI discovered this while running the tests by hand as part of studying them to understand how these functions worked since I was running out of disk during a long running data-intensive session involving flowWorkspace.