RGLab / openCyto

A package that provides data analysis pipeline for flow cytometry.
GNU Affero General Public License v3.0
75 stars 29 forks source link

Evaluate minEvents gating argument for CytoExploreR. #253

Closed djhammill closed 4 months ago

djhammill commented 4 months ago

@mikejiang, a recent change in the latest version of R is causing issues for CytoExploreR.

I've tracked down the issue as described in this ticket.

Basically all gating arguments are passed in as calls which get automatically evaluated during this do.call() chunk which invokes the gating function. The minEvents argument is dropped from this list and therefore remains a call when the event number check is performed.

To be safe I have wrapped the call evaluation in an if statement.

Adding @mikejiang for review as this fix is required on BioC for CytoExploreR to work - first reported here.

mikejiang commented 4 months ago

Thank you for the investigation&&patch

mikejiang commented 4 months ago

pushed to bioconductor