search

RGLab / openCyto

A package that provides data analysis pipeline for flow cytometry.
GNU Affero General Public License v3.0
77 stars 29 forks source link

ODC-182 Support logical and factor CytoExploreR's clustering #260

Open djhammill opened 2 weeks ago

djhammill commented 2 weeks ago

@amcdavid adding PR here to implement features or fixes required by CytoExploreR please see https://ozette.atlassian.net/browse/ODC-182

NOTE: This is draft PR it is known to causes issues for some edge cases, I will investigate a better solution and update this PR.

djhammill commented 2 weeks ago

I am thinking that maybe we should only invoke the new code if the gating function is cyto_gate_clust() - that will ensure that everything behaves normally within openCyto and CytoExploreR.

djhammill commented 2 weeks ago

Alternatively we separate out filter and filters objects from logical and factor and treat those separately. It doesn't make sense to replicate event-wise logical or factor filters across multiple samples where the event number may be different. I will try converting the gates within CytoExploreR to be either logical or factor to see if I can get it to work.