RHEcosystemAppEng / starburstaddon-operator

Operator to deploy the Starburst Addon
1 stars 2 forks source link

Add clusterID functionality for prometheus external labels #2

Closed tsisodia10 closed 1 year ago

cmwylie19 commented 1 year ago

Hi Twinkll, I am having some problems with the dependencies.

➜  starburstaddon-operator git:(clusterID) ✗ make generate
test -s /Users/caseywylie/starburstaddon-operator/bin/controller-gen || GOBIN=/Users/caseywylie/starburstaddon-operator/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.10.0
/Users/caseywylie/starburstaddon-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
controllers/starburstaddon_controller.go:24:2: no required module provides package github.com/openshift/api/config/v1; to add it:
        go get github.com/openshift/api/config/v1
Error: not all generators ran successfully
run `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -h` for usage
make: *** [generate] Error 1

I am unable to install this dependencies in the way that is listed:

➜  starburstaddon-operator git:(clusterID) go get github.com/openshift/api/config/v1
go: module github.com/openshift/api@upgrade found (v3.9.0+incompatible), but does not contain package github.com/openshift/api/config/v1

How did you get around this?

cmwylie19 commented 1 year ago

Hi Twinkll, I am having some problems with the dependencies.

➜  starburstaddon-operator git:(clusterID) ✗ make generate
test -s /Users/caseywylie/starburstaddon-operator/bin/controller-gen || GOBIN=/Users/caseywylie/starburstaddon-operator/bin go install sigs.k8s.io/controller-tools/cmd/controller-gen@v0.10.0
/Users/caseywylie/starburstaddon-operator/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
controllers/starburstaddon_controller.go:24:2: no required module provides package github.com/openshift/api/config/v1; to add it:
        go get github.com/openshift/api/config/v1
Error: not all generators ran successfully
run `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -h` for usage
make: *** [generate] Error 1

I am unable to install this dependencies in the way that is listed:

➜  starburstaddon-operator git:(clusterID) go get github.com/openshift/api/config/v1
go: module github.com/openshift/api@upgrade found (v3.9.0+incompatible), but does not contain package github.com/openshift/api/config/v1

How did you get around this?

I chatted with Twinkll in gchat and she showed me the workaround for this issue. Posting this here incase someone else needs it:

➜  starburstaddon-operator git:(clusterID) go get github.com/openshift/api/config/v1@master
go: downloading github.com/openshift/api v0.0.0-20230106230226-5ad311dde226
go: added github.com/openshift/api v0.0.0-20230106230226-5ad311dde226
cmwylie19 commented 1 year ago

I am getting errors about the configv1 not added to the scheme. Likely was accidentally left out of the commit - Adding this now in the main.go file.

1.673295109783911e+09   ERROR   controller-runtime.source  kind must be registered to the Scheme      {"error": "no kind is registered for the type v1.ClusterVersion in scheme \"pkg/runtime/scheme.go:100\""}
cmwylie19 commented 1 year ago

LGTM and works