search

RHInception / jsonstats

system stats over rest in json (buzzzzwords here)
MIT License
22 stars 8 forks source link

Ping module #29

Closed magnus919 closed 10 years ago

magnus919 commented 10 years ago

This pull request will provide the Ping module requested in https://github.com/RHInception/jsonstats/issues/26. It will not provide the URL context to selectively run individual modules as specified later in the comments of that request (work in progress).

tbielawa commented 10 years ago

@magnus919 can you check out those pep8 failures from the travis build results?

tbielawa commented 10 years ago

I was going to suggest using the UUID module http://docs.python.org/2/library/uuid.html but it has only been in stdlib since 2.5. Supporting legacy systems sucks!

Returning a UUID is a good idea, but unfortunately you can't depend on the uuidgen command being available everywhere. For example, on my stock Debian 7 AWS instance:

root@ip-:~# uuidgen
-bash: uuidgen: command not found

I'm leaning more towards the idea of using the timestamp plugin ( #8 #24 ) for ping functionality. I may end up just closing this PR (though I do appreciate your effort!) along with my original issue, #26