The removed-rules test doesn't really fit the diff category - all other tests are expected to fail + failures reviewed manually, but removed-rules works more like a traditional regression test, it should never fail.
Moving it outside would mean breaking access to shared (which includes "get me old content" logic), which is why I was reluctant to do that so far.
However we now need other tests with access to that functionality - namely the replacement for Sanity/test-hardening-pkg-update which should not be in diff anyway.
So
move the shared functionality to somewhere in lib
move removed-rules out of diff, into /static-checks
create a replacement for Sanity/test-hardening-pkg-update (in /hardening probably) using the functionality
comps
commented
4 months ago
The
removed-rulestest doesn't really fit thediffcategory - all other tests are expected to fail + failures reviewed manually, butremoved-rulesworks more like a traditional regression test, it should never fail.Moving it outside would mean breaking access to
shared(which includes "get me old content" logic), which is why I was reluctant to do that so far.However we now need other tests with access to that functionality - namely the replacement for
Sanity/test-hardening-pkg-updatewhich should not be indiffanyway.So
sharedfunctionality to somewhere inlibremoved-rulesout ofdiff, into/static-checksSanity/test-hardening-pkg-update(in/hardeningprobably) using the functionality