RHSecurityCompliance / contest

Content Testing for ComplianceAsCode/content
Other
4 stars 7 forks source link

Clean up FMF definitions - TCMS, tags, variables #236

Closed comps closed 1 month ago

comps commented 1 month ago

This removes now-useless TCMS metadata, as well as seemingly undocumented tags (not in docs/TESTS.md) and makes /hardening tests parse profile name from the test name, rather than from a separate PROFILE variable.

I couldn't decide whether ie.

/anssi_bp28_high:
/cis:
/cis_server_l1:
/cis_workstation_l1:
/cis_workstation_l2:
/cui:
    adjust+:
      - when: distro >= rhel-10
        enabled: false
        because: there is no CUI profile on RHEL-10+
/e8:
/hipaa:
/ism_o:
/ospp:
/pci-dss:
/stig:
/stig_gui:
    adjust+:
      - enabled: false
        because: not supported without GUI, use stig instead
/ccn_advanced:
    adjust+:
      - when: distro == rhel-8
        enabled: false
        because: CNN Advanced profile is specific to RHEL 9

looked better than spacing each profile name with a newline, so I left the newlines in. If you prefer the compacted version, I can update the PR.

Tested on all /hardening/.*/cis$ to exercise every test, and it seems to work. I'd like to do a full productization run before merging this PR, though.