RHsyseng / openshift-checks

A collection of scripts to check the health of an OpenShift cluster
53 stars 44 forks source link

CLI and HTML report not consistent #131

Open ribua opened 1 year ago

ribua commented 1 year ago

Hi ,

Reporting issues for checks that are working from CLI and report indicates the following messages.

./openshift-checks.sh -s checks/zombies
Using system:serviceaccount:ribu-test:sa-kubeconfig context
Collecting zombie processes... (using oc debug, it can take a while)
No issues found

The above when run via HTML report just indicates the below information

image

The page doesn;t refresh with the new information or final results.

Ribu

iranzo commented 1 year ago

It reports the status as 'OK' in the HTML interface. The 'No issues found' is equivalent to the 'OK' as reported by the CLI interface:

  if [ ${errors} -gt 0 ]; then
    die "${RED}Total issues found: ${errors}${NOCOLOR}"
  else
    msg "${GREEN}No issues found${NOCOLOR}"
  fi
iranzo commented 1 year ago

@ribua Try and paste the output of risu.py -l -i zombies -v here

gitkent commented 1 year ago

Hi all, I am working with @ribua for this issue. Please find below output from risu.py -l -i zombies -v

❯ risu.py -l -i zombies -v
INFO:risu:Storing output on file reports/osc.json

[l%%%l]=[]=

# checksroot/nagios/checks/zombies: okay
iranzo commented 1 year ago

Hi @gitkent

So that confirms what I was mentioning, the difference in the reporting comes from the openshift-checks.sh wrapper. Graphical or risu console output of 'okay' is the equivalent of the wrapper saying 'No issues found'.

There was a PR for making the openshift-checks.sh more silent at #113