RHsyseng / openshift-checks

A collection of scripts to check the health of an OpenShift cluster
53 stars 44 forks source link

[enhancement/bugfix] Make zombie a check and fix error return for parallel jobs #93

Closed loganmc10 closed 2 years ago

loganmc10 commented 2 years ago

This moves "zombies" from info to check, and fails if there are 5 or more zombies.

Additionally, I noticed that there is a problem with error checking when using parallel processes.

Because the checks are done in a subprocess, any edits to "errors" aren't reflected in the main check script. Instead, I write a "1" to a temporary file, and use that to check for errors once all the processes have completed.

dcritch commented 2 years ago

works for me. thanks! good catch on the parallel jobs!