Feature foxglove bridge - Githubissues

RI-SE / ATOS

ROS2 based platform for coordinating tests of automated vehicles and their surrounding systems.

Mozilla Public License 2.0

13 stars 5 forks source link

Feature foxglove bridge #607

Closed victorjarlow closed 9 months ago

victorjarlow commented 11 months ago

Updated docs to point users toward the foxglove studio docker implementation instead of studio.foxglove.dev.
Adopted foxglove_bridge as the default bridge, instead of ros_bridge (see motivation here: https://github.com/foxglove/ros-foxglove-bridge#motivation).
Added options to launch_basic such that bridge security and implementation can be controlled.
Updated install instructions and install script
Logs end up in ~/.ros/logs/date-xx-xxx/launch.log on my system (I have not set ROS_HOME or ROS_LOG_DIR)

example: ros2 launch atos launch_basic.py insecure:=True foxbridge:=True

If no input arguments are specified, the options are set to insecure=False, foxbridge=True.

Motivation for this PR:

The PR removes the need for accepting https://localhost:3443 certificate
The need for accepting the https://localhost:8765 certificate still remains..
We can change the standard ros launch command to "ros2 launch atos launch_basic insecure:=True" to highlight that the bridge protocol is insecure and that the user can do extra steps (accept cert at https://localhost:8765) in order to simply use the default launch command, but this requires extra steps.

victorjarlow commented 10 months ago

@Robert108 requesting re-review