Closed SebastianSvanland closed 7 months ago
Looks really good, nice work!
Here's a very short review, we can continue reviewing this in January.
gui/controlpanel
and gui/src
, which might be confusing. Maybe we should have a controlpanel
directory and a configpanel
directory, and a directory for the shared code or something like that.Browse...
to ~/.astazero/ATOS/
instead?.xosc
-file, does this it send the full path or only the name? We append ~/.astazero/ATOS/osc/
in EsminiAdapter and if it sends the full path this is not going to work. Maybe a feature that should be added in another PR is to being able to load a scenario file that is located anywhere and not only in ~/.astazero/ATOS/osc/
.
New config panel. Go to localhost:3000/configpanel to try it out. No ATOS modules support this gui so far, but the ROS parameters are requested from each node at least. Needed to do some restructuring in the previous controlpanel as well so this PR works towards multiple tickets.
I've been working on this for a while now so I've gone blind for all the variable/function names. Would appreciate if someone could help me clean it up, right now it's a mess. Also check the descriptions/title of all the parameters, I didn't fully understand what all of them did so I just made something up for now. You can either see this in the gui immediately when entering value for each parameter, or check out json-schema
There is a known issue where the config gui doesn't send the ros parameters for all nodes. Don't really know why that is yet.