search

RIAEvangelist / awesome-webcomponents

Other
13 stars 2 forks source link

Awesome-login-screen data action path not preventing standard auth from loading. #37

Closed MaybeRex closed 8 years ago

MaybeRex commented 8 years ago

awesome-login-screen

awesome-login-sceen data-action path should accept a template string as a path

RIAEvangelist commented 8 years ago

you need to make better titles.

RIAEvangelist commented 8 years ago

also, your bug report states what it should be doing. so its not reporting anything.

RIAEvangelist commented 8 years ago

should read similar to the following :

if awesome-login-sceen data-action path is specified it should prevent the default auth from loading, but both are still loading.

RIAEvangelist commented 8 years ago

reporting bugs clearly is a very important skill if you want them to be fixed. ;)

asida18 commented 8 years ago

To load one's own action for use in awesome-login-screen within a html screen or index, we must currently do as so within the script tags:

const login=document.createElement('awesome-login-screen'); login.dataset.action_path=${proprietaryrepo.path}actions/yourAuth.js; window.on( 'DOMContentLoaded', function(){ document.body.appendChild(login); } )

Please change to solution shown below :

const login=document.createElement('awesome-login-screen'); login.dataset.action_path=${proprietaryrepo.path}actions/yourAuth.js; awesome.appendComponent(login);

RIAEvangelist commented 8 years ago

plz make new issue @asida18