RIAEvangelist / node-dominos-pizza-api

This is a node.js wrapper for the dominos pizza apis
MIT License
538 stars 129 forks source link

package json tests need to be added as scripts #10

Closed RIAEvangelist closed 9 years ago

RIAEvangelist commented 9 years ago

A good example for what needs to be added to dev dependancies and script keys can be found here https://github.com/senchalabs/connect/blob/master/package.json

add in whatever your testing dependencies are.

RIAEvangelist commented 9 years ago

Once this one is done, I'll be excited to run the suite.

madelinecameron commented 9 years ago

Yeah, I can definitely start working on this tonight.

RIAEvangelist commented 9 years ago

sweet!

madelinecameron commented 9 years ago

Just an update, I have 4 out of 11 tests passing (No tests written for actual order placing or order tracking, may have to figure out a way to test those without actually ordering)

I made a few changes to code (Namely the Address object) so I will push everything tomorrow / tomorrow evening.

The changes to the Address object are:

EDIT: Pushed it into the PizzaPI branch in case anyone wants to mess with changes over night.

RIAEvangelist commented 9 years ago

awesome. Can you add the command to run tests manually in the ReadMe?

madelinecameron commented 9 years ago

Yeah definitely. It is just 'mocha' but I'll add it.

RIAEvangelist commented 9 years ago

fixed by b7d2cb7