search

RIAEvangelist / node-dominos-pizza-api

This is a node.js wrapper for the dominos pizza apis
MIT License
544 stars 129 forks source link

Modernizing tests for speed #83

Closed workingjubilee closed 3 years ago

workingjubilee commented 5 years ago

I don't particularly expect this PR to land, but I modernized all the tests using Jest for the sake of speed. While Mocha is a more mature testing library, the Mocha/Chai testing suite was not doing anything particularly wild, so I elected to use the faster Jest test library as the original tests required a LOT of time to resolve. In addition, I updated the packages, they're not perfect in their current form but it should resolve security issues. Basically, just a quick round of maintenance. I hope you see and merge this @RIAEvangelist!

RIAEvangelist commented 3 years ago

@workingjubilee Thank you for this, I am actually converting everything to ES6 right now and integrating a lot of update requests.

I'll be updating for security as well. And for testing, I will probably use vanilla-test

Thank you so much for the contribution though. Apologies I was not around to accept it. I crushed my spine and was rebuilt with titanium June of 2018 and it took me a LONG time to recover.

Hopefully, you will approve of the new module, which sadly will be breaking in order to allow for a more normalized interface.