search

RIDGIDSoftwareSolutions / Universal-Analytics-For-DotNet

A .NET wrapper over top of Google's Universal Analytics Measurement Protocol API
MIT License
14 stars 5 forks source link

Add support for optional UserId #5

Closed jakejgordon closed 6 years ago

jakejgordon commented 9 years ago

Allow the client ID to be optional instead of required, as it states in the documentation here: https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#cid

yaronguez commented 7 years ago

Was this feature ever added?

jakejgordon commented 7 years ago

Hi @yaronguez I think the purpose of this issue is to make the CID optional instead of required as it states here: https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#cid -- which I don't think was ever done. Does that answer your question?

yaronguez commented 7 years ago

Yes, if the CID was optional than the UID could provided instead. You're saying that this isn't possible with this library?

Yaron Guez Software Architect (781) 249-4709

On Fri, Jan 6, 2017 at 4:27 AM, Jake Gordon notifications@github.com wrote:

Hi @yaronguez https://github.com/yaronguez I think the purpose of this issue is to make the CID optional instead of required as it states here: https://developers.google.com/analytics/devguides/collection/protocol/v1/ parameters#cid -- which I don't think was ever done. Does that answer your question?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/RIDGIDSoftwareSolutions/Universal-Analytics-For-DotNet/issues/5#issuecomment-270894275, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXdwz7SA-e-wo1mspru3ROdYwEHE78Oks5rPjNAgaJpZM4EAv0n .

jakejgordon commented 7 years ago

Sorry for the delayed response. Right now it does not accept userId. You can add support via a Pull Request or I could try to take a stab at it in the next week or so -- it should be pretty easy. Let me know.

yaronguez commented 7 years ago

Thanks! Let me know if you get a chance to add this feature in the next week or so.

yaronguez commented 7 years ago

Hi @jakejgordon, did you ever find the time to add that feature?

jakejgordon commented 7 years ago

Sorry Yaron -- I actually did not. I'm really sorry I forgot to response. Realistically, I probably won't get to this for another couple of weeks. If this is a major problem or a deal-breaker for you let me know and I'll see what I can do.

yaronguez commented 7 years ago

No worries, Jake. It's an open source project after all. I'll just call the Analytics API directly using the HttpClient class.

cogree commented 6 years ago

This is currently supported in version 1.4.4 of the Nuget package. Closing.