RIOT-OS / RIOT

RIOT - The friendly OS for IoT

https://riot-os.org

GNU Lesser General Public License v2.1

4.87k stars 1.98k forks source link

periph/timer: `timer_set()` underflow safety check (tracking issue) #13072

Open kaspar030 opened 4 years ago

kaspar030 commented 4 years ago

Description

13060 added timer_set() protection from IRQ.

There are a couple of other implementations that need to be reviewed for irq safety (found with git grep 'int.*timer_set('):

[x] esp32/periph/timer.c (two impls.)
[x] esp8266/periph/timer.c (two impls)
[ ] fe310/periph/timer.c
[ ] kinetis/periph/timer.c
[ ] mips32r2_common/periph/timer.c

IMO we should take a close look at all of them. Also, confirm whether they're actually needed or can just be replaced by the generic one.

All four esp implementation seem to internally protect from irqs. @gschorcht maybe confirm?

gschorcht commented 4 years ago

All four esp implementation seem to internally protect from irqs. @gschorcht maybe confirm?

Confirmed :wink: