search

RIOT-OS / RIOT

RIOT - The friendly OS for IoT
https://riot-os.org
GNU Lesser General Public License v2.1
4.94k stars 1.99k forks source link

suit: remove duplicate CoAP code #13330

Open bergzand opened 4 years ago

bergzand commented 4 years ago

Description

From sys/include/suit/coap.h:

/*                                                                               
 * Dear Reviewer,                                                                
 *                                                                               
 * At the time of PR'ing this code, there was a pile of CoAP PR's waiting for    
 * reviews.  Some of that functionality is needed in one way or another for      
 * SUIT. In order to not block software updates with CoAP refactoring, some of   
 * the work-in-progress code has been copied here.  We expect this to be         
 * removed as soon as CoAP in master provides similar functionality.             
 *                                                                               
 * As this is internal code that will go soon, I exclude this from Doxygen.      
 *                                                                               
 * Kaspar (July 2019)                                                            
 */

@kaspar I think it is time we start to clean this code up :wink:.

Useful links

None

aabadie commented 4 years ago

@bergzand any plan soon to address the 2 remaining points ? ;)

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

miri64 commented 3 years ago

I guess this is still an issue, right?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

miri64 commented 2 years ago
  • CoAP blockwise request callback

this was solved recently, right?