search

RIOT-OS / RobotFW-tests

Includes tests for RIOT based on the Robot Framework
GNU Lesser General Public License v2.1
4 stars 13 forks source link

tests/periph_i2c: Add start, stop flag i2c tests #26

Closed MrKevinWeiss closed 5 years ago

MrKevinWeiss commented 5 years ago

Description

This PR expands I2C tests to test the different i2c frames such as write_bytes with I2C_NOSTOP or I2C_NOSTART

Some issues and lockups occur when using split frames Tests are added to expose these issues Not all functions are supported but still are tested

Testing

Run the make robot-test -C tests/periph_i2c on some boards

Expected Results

Not everything should pass but every test should be passing somewhere (so maybe failing on a nucleo-f091rc but it would pass on a nucleo-f401re)

MrKevinWeiss commented 5 years ago

I don't know if you want to merge fast because I know it will point out many problems. Some problems are very difficult to actually solve due to the hardware limitations (at least I couldn't think of any) and are documented in the API as a limitation.

smlng commented 5 years ago

every board seems to have "problems" with the added tests, so would be nice to see at least some all green before merging or we work with the non-critical tag?

MrKevinWeiss commented 5 years ago

Arg did you look at the failures... My bad.

MrKevinWeiss commented 5 years ago

Seems better. I believe these are the failures/unsupported features I wanted to expose.

smlng commented 5 years ago

still every board has at least 1 fail 😞

MrKevinWeiss commented 5 years ago

No one test fails on every board.

MrKevinWeiss commented 5 years ago

I know how to break things, I just wanted to do little by little otherwise it becomes too overwhelming to fix.

MrKevinWeiss commented 5 years ago

rebased and squashed. Should be good to go!