search

RIOT-OS / RobotFW-tests

Includes tests for RIOT based on the Robot Framework
GNU Lesser General Public License v2.1
4 stars 13 forks source link

feat(conf): Add board default pin configuration #46

Closed MrKevinWeiss closed 4 years ago

MrKevinWeiss commented 4 years ago

This adds pinout locations for select boards. The purpose is to allow a repository for how to wire the DUT to PHiLIP. This can be used for CI exports or user exports.

This reflects the pinout currently used in the HIL setup

MrKevinWeiss commented 4 years ago

I guess I could use feedback, should I have empty fields to make boilerplate things easier or go for less clutter?

Should I add an export in front of everything?

Should it be a ?= instead of =

I wanted to preserve the *_GPIO names, the original idea was to put them in a comment but with it as a var we may want to use it in the future for a show pinout command, it contains the port/pin, the label on the board, and the connector location.

MrKevinWeiss commented 4 years ago

ping @smlng, maybe tomorrow we can get something decided since the SPI can really use this.

MrKevinWeiss commented 4 years ago

I still have a bit of a problem with application discovery. It currently doesn't try to check the application...

smlng commented 4 years ago

put this into Makefile.test_common:

include $(TESTBASE)/dist/etc/conf/$(BOARD).env
MrKevinWeiss commented 4 years ago

I added a number of things, maybe we could split them. I think everything should be prefixed with HIL_ including the common things, this would make all env variables introduced specifically for these tests.

The question is should it be like that for PHILIP_PORT and PORT, should there be an abstraction (at some point we go PORT=HIL_DUT_PORT)?

I think with all this information we can actually generate a pinout for the boards that have the env setup.

Also I want to introduce the idea of USE_HILDA if we want to use a BPH+PI setup. I am afraid this is going in the direction of CI driven development though. It still has a purpose, for example when I ssh into a pi with the ancible setup I would want to just say USE_HILDA=1 BOARD=<my_board> make flash robot-test -C <my_test>, the USE_HILDA could also be done in the env setup though... I guess so can all the parameters. This may be useful later if we want to say, have the possibility of hard poweroff of the DUT or use any BPH commands.

Anyways lots to talk about.

MrKevinWeiss commented 4 years ago

Lets see what the CI catches.

MrKevinWeiss commented 4 years ago

It seems like the CI is happy. Should I squash?

MrKevinWeiss commented 4 years ago

Thanks!