search

RIOT-OS / RobotFW-tests

Includes tests for RIOT based on the Robot Framework
GNU Lesser General Public License v2.1
4 stars 13 forks source link

feature(i2c): Add read bytes nack test #6

Closed MrKevinWeiss closed 5 years ago

MrKevinWeiss commented 5 years ago

A bug was found when multiple nacks due to read bytes were issued. This test identifies this bug by reading the incorrect bytes multiple times then trying to recover with read byte.

MrKevinWeiss commented 5 years ago

@smlng This was a pretty stupid bug in the i2c_2.c implementation for stm f1 or f4. It may be better to verify the error I get is a NACK?

I look forward to your feedback.

smlng commented 5 years ago

you seem to have an outdated master branch there are some conflicts

MrKevinWeiss commented 5 years ago

How do you want to do this, should we trigger manual tests first or just let it show up in the HiL nightlies (instamerge)?

smlng commented 5 years ago

How do you want to do this, should we trigger manual tests first or just let it show up in the HiL nightlies (instamerge)?

I will run them manually later today, if it looks good I'll merge and we see official result tomorrow.

MrKevinWeiss commented 5 years ago

Could you also run it against maybe a commit from last week so we can see the error?

smlng commented 5 years ago

tested (and works) with latest master on nucleo f4, but fails (as expected) on older commits (e.g. last release). ACK!

MrKevinWeiss commented 5 years ago

Super cool. And so it starts!