search

RIOT-OS / riot-os.org

Sources of the RIOT website https://riot-os.org/.
4 stars 16 forks source link

Make FAQs linkable #127

Closed miri64 closed 4 months ago

miri64 commented 4 months ago

This makes FAQs linkable, as discussed in https://github.com/RIOT-OS/riot-os.org/pull/125/commits/ef6c8e309bebd793edb00724f457956bb73bb366#r1574781620 (and also piggy-backs a small fixup to make an absolute URL a clickable link).

github-actions[bot] commented 4 months ago

🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-127.surge.sh

maribu commented 4 months ago

Thx, https://riot-os-riot-os-org-preview-127.surge.sh/#faq-why-lgpl works for me even when the item is not expanded :)

miri64 commented 4 months ago

Also, would you mind fixing the todo in faq-12.md now that it's possible?

It's not addressed yet, since I am not sure how it was meant in this context. Where should the link go?

miri64 commented 4 months ago

Just noticed that the respective anchor item is scrolled to the very top of the window and thereby hidden by the website header. Probably another follow-up issue/PR?

That's "normal" behavior for web browsers. Anything beyond would need some CSS or even JS magic. Not sure we want that just to get the scroll-point right.