search

RIOT-OS / riot-os.org

Sources of the RIOT website https://riot-os.org/.
4 stars 16 forks source link

External pages should open as `_blank` target #26

Closed miri64 closed 3 years ago

miri64 commented 3 years ago

This issue was raised on the forum during the initial discussion on the original demonstrator.

miri64 commented 3 years ago

Are there still non _blank external links with #37 merged?

jia200x commented 3 years ago

Yes!

miri64 commented 3 years ago

Yes!

Why close then?

leandrolanzieri commented 3 years ago

😄 I think he meant there are no links without _blank left

miri64 commented 3 years ago

The company links in the user story posts still open in the same tab. E.g. "LOCHA MESH" here https://relaunch.riot-os.org/use_cases/locha.html. But I think for this either the markdown source needs to be adapted or a dedicated plugin needs to be installed.

waehlisch commented 3 years ago

we don't need a separate plugin to enable this.

miri64 commented 3 years ago

we don't need a separate plugin to enable this.

Then the markdown needs to be adopted to add the target="_blank" attribute to external links within generated content.

jia200x commented 3 years ago

I think he meant there are no links without _blank left

Yes, I meant that. sorry

leandrolanzieri commented 3 years ago

we don't need a separate plugin to enable this.

Then the markdown needs to be adopted to add the target="_blank" attribute to external links within generated content.

@miri64 this has been fixed in #70