search

RIOT-OS / riot-os.org

Sources of the RIOT website https://riot-os.org/.
4 stars 16 forks source link

includes/use_cases_carousel: limit quote lines #53

Closed leandrolanzieri closed 3 years ago

leandrolanzieri commented 3 years ago

Contribution description

This PR removes the rounding of logos in the use-cases pages, and makes the carousel of equal height by limiting the number of lines in the quotes, as described in #52.

For testing I suggest rebasing on top of #51, which introduces a quote that is smaller than the current ones.

Fixes #52.

github-actions[bot] commented 3 years ago

🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-53.surge.sh

waehlisch commented 3 years ago

hmm, regarding the use cases cards: would be good to have a closing quote sign ("). i would also prefer three lines instead of two to show a bit more content.

leandrolanzieri commented 3 years ago

hmm, regarding the use cases cards: would be good to have a closing quote sign (").

This was removed by the line-clamp property, because the icons are part of the content. Now I enclosed the quote in a span and applied the properties to that.

i would also prefer three lines instead of two to show a bit more content.

Done