search

RIOT-OS / riotdocker

Dockerfiles for creating build environment for building RIOT projects.
34 stars 45 forks source link

riotbuild: bump esp32x toolchains to gcc version 12.2 #227

Closed gschorcht closed 1 year ago

gschorcht commented 1 year ago

This PR upgrades ESP32x toolchains to GCC version 12.2. Since ESP-IDF 5.1 requires this compiler version, this PR has to be merged before we can start with RIOT upgrade to ESP-IDF 5.1.

This PR depends on https://github.com/RIOT-OS/RIOT/pull/19450.

gschorcht commented 1 year ago

@kaspar030 The build test had to fail when I pushed the PR because https://github.com/RIOT-OS/RIOT/pull/19450 was not merged. Now it should succeed. How can we restart the build test?

kaspar030 commented 1 year ago

@kaspar030 The build test had to fail when I pushed the PR because RIOT-OS/RIOT#19450 was not merged. Now it should succeed. How can we restart the build test?

I guess someone restarted it?

Anyhow, it probably still won't succeed. This repository doesn't build RIOT master but some older branch as defined here.

That needs to be bumped first. (Which we usually rather not do during final release testing ...)

Can this wait until after the release?

gschorcht commented 1 year ago

That needs to be bumped first. (Which we usually rather not do during final release testing ...)

:+1:

Can this wait until after the release?

Yeah, of course. After the release we should not wait too long before inconsistencies happen between the last state of ESP32 code and the new compiler version. I compiled all the apps for all ESP32x plattforms with current master locally two weeks ago.

kaspar030 commented 1 year ago

After the release we should not wait too long before inconsistencies happen between the last state of ESP32 code and the new compiler version.

I PR'ed the version bump, we can rerun this.

kaspar030 commented 1 year ago

Pls rebase!

gschorcht commented 1 year ago

Rebased, but it seems that the compile test still used the old code base. When you look for example on the first error in the log, this problem was changed with PR 19450.

kaspar030 commented 1 year ago
kaspar030 commented 1 year ago

bors merge

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.